nuttxpr commented on PR #15069: URL: https://github.com/apache/nuttx/pull/15069#issuecomment-2521941526
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) ## Does this PR meet the NuttX Requirements? **No.** The provided information is insufficient to determine if the PR meets the NuttX requirements. While the summary explains the *what* and *why*, it lacks the *how*. The impact and testing sections are essentially placeholders. **Specifically lacking:** * **Summary:** Missing a detailed explanation of *how* the macro works, how it's configured, and its default state. Also missing related issue references. * **Impact:** All impact areas need to be addressed with "YES" or "NO" and a description if "YES." The current placeholder text needs to be replaced with specific details. Crucially, the impact on the user needs to be clarified. Will they need to explicitly enable this TCP DNS feature? How? * **Testing:** Completely missing. Needs details about the build host (OS, CPU, compiler version), the target platform (architecture, board, configuration), and, most importantly, the *actual* test logs from before and after the change. Simply stating that it "works as intended" is insufficient. Show the failure before the change and the success after. Demonstrate that the macro effectively controls the behavior. **To make this PR acceptable, the author needs to:** 1. **Expand the Summary:** Explain the mechanism of the new macro. How is it defined? How is it used to enable/disable the TCP DNS feature? What's the default setting? Link any relevant NuttX issues. 2. **Complete the Impact Assessment:** Replace the placeholder text with concrete answers (YES/NO) and descriptions for *all* impact categories. Pay particular attention to the user impact: how will they interact with this new macro? 3. **Provide Thorough Testing Information:** Specify the build host and target details. Include *actual* log output demonstrating the issue before the change, and the resolved issue after the change. Show how the macro controls the behavior. Ideally, include tests that demonstrate both the enabled and disabled states of the feature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
