nuttxpr commented on PR #15072: URL: https://github.com/apache/nuttx/pull/15072#issuecomment-2522018557
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) This PR does *not* fully meet the NuttX requirements yet. While it provides a summary and mentions impact and testing, it lacks crucial details. Here's a breakdown: **Missing/Insufficient Information:** * **Summary:** While the title gives a general idea, the summary needs more detail. It should explain *why* aligning the memory barrier interface with RISC-V is necessary. What problem does it solve? What are the benefits? Is this a bug fix, a performance improvement, or something else? It also lacks any mention of related issues. * **Impact:** The placeholder text remains. The author *must* fill out this section with specifics. Even if the answer is "NO" for each item, it should explicitly state that. For example, "Impact on user: NO". If there *is* an impact, it needs a description. For instance, if the change affects driver code, explain how. * **Testing:** The placeholder text remains. This section is critical. The author needs to provide concrete details about their testing environment (host OS, compiler version, target architecture, board, configuration) and include actual logs from before and after the change to demonstrate the impact and verify the fix/improvement. Simply saying "works as intended" is not sufficient. **To make this PR compliant, the author needs to:** 1. **Expand the Summary:** Provide a detailed explanation of the change's purpose and rationale. Include links to any related issues. 2. **Complete the Impact Section:** Address each point specifically, even if the answer is "NO". Provide detailed explanations for any "YES" answers. 3. **Provide Thorough Testing Information:** Specify the host and target environments used for testing and include *actual* logs demonstrating the behavior before and after the change. By providing this missing information, the PR will meet the NuttX requirements and enable reviewers to effectively evaluate the proposed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
