nuttxpr commented on PR #15092: URL: https://github.com/apache/nuttx/pull/15092#issuecomment-2527863806
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR summary lacks crucial information. It doesn't explain *why* removing `spin_lock_irqsave(NULL)` is desirable (what problems does it solve/prevent?). It also doesn't explain *how* the change works (what locking mechanism replaces it?). The impact section is too brief, only mentioning the affected file, not the broader impact. The testing section doesn't provide any actual logs, only stating "ci ostest," which is insufficient to verify functionality. A proper description of the test setup (board, configuration) is also missing. Finally, it doesn't reference any related issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
