nuttxpr commented on PR #15175: URL: https://github.com/apache/nuttx/pull/15175#issuecomment-2540846478
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides a summary and mentions testing with CI, it lacks crucial details. Here's what's missing: * **Summary:** Lacks detail. *Why* is this cleanup necessary? What problem does it solve? How exactly does the removal of `g_system_ticks` work when the architecture timer is enabled? What is the functional change? The linked PR should be referenced in the "Related NuttX Issue" section, not embedded within the summary. * **Impact:** Simply stating "RELEASE" is insufficient. Each impact category needs to be addressed with "YES" or "NO" and a description if "YES". For example, even if there's no user impact, explicitly state "Impact on user: NO". Consider the implications of this change. Does it improve performance? Reduce memory usage? Does it affect any specific architectures, boards, or drivers? Does this change require documentation updates? * **Testing:** "CI" is not sufficient. While CI testing is important, local testing details are required. Provide the specific build host OS, CPU, compiler, and the target architecture, board, and configuration used for testing. Critically, the testing logs *before* and *after* the change are missing. These logs demonstrate the issue the PR addresses and confirm the fix. Just saying it "works as intended" isn't enough; show *how* it works as intended. In short, the PR needs to be much more descriptive and provide concrete evidence of testing and impact analysis to meet the NuttX requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
