nuttxpr commented on PR #15198: URL: https://github.com/apache/nuttx/pull/15198#issuecomment-2544411040
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although the testing section could be improved. While the PR provides information on the host and target, it lacks specific "before" and "after" testing logs. Simply stating "Passed the file system related syscall test" is insufficient. Concrete examples of commands run and their output, both before and after the change, are crucial for reviewers to assess the impact and correctness of the patch. Even if the output is identical, showing the commands and output demonstrates that the tests were actually run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
