nuttxpr commented on PR #15288: URL: https://github.com/apache/nuttx/pull/15288#issuecomment-2553335687
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** While it explains the "why," it's vague on the "what" and "how." It mentions `NBYTES` and `RELOAD` but doesn't explain what those are or precisely how they're being modified. The reference to #12093 is helpful but insufficient; the PR should stand on its own. * **Impact:** This section is almost entirely empty. This is a critical part of the review process. At a minimum, the author needs to assess and document the impact on hardware (since it affects all STM32 chips) and compatibility. Even if the answer is "NO" for most categories, it needs to be explicitly stated. * **Testing:** While testing logs are provided, they lack context. What test was run? What constitutes success/failure? More importantly, testing on a single STM32F7 board is insufficient given the claim that the change affects *all* STM32 chips. A broader range of testing is needed or, at least, a justification for why it wasn't possible. The author acknowledges this limitation, but needs to address it more directly (e.g., propose a plan for wider testing or request help from maintainers with access to other hardware). In short, the PR needs more detail and more thorough testing before it can be properly reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
