wengzhe commented on code in PR #15285: URL: https://github.com/apache/nuttx/pull/15285#discussion_r1895167240
########## net/bluetooth/bluetooth_conn.c: ########## @@ -42,10 +42,19 @@ #include <nuttx/net/bluetooth.h> #include "devif/devif.h" +#include "utils/utils.h" #include "bluetooth/bluetooth.h" #ifdef CONFIG_NET_BLUETOOTH +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +#ifndef CONFIG_NET_BLUETOOTH_MAX_CONNS +# define CONFIG_NET_BLUETOOTH_MAX_CONNS 0 Review Comment: It's because the default value of max_conns is 0 (https://github.com/apache/nuttx/blob/master/net/bluetooth/Kconfig#L57) and I found it means no limit because everywhere we use it to limit connections is checking `#if max_conns > 0`. In this PR I set the `sem` to `INT16_MAX` in `net_bufpool_init` to get similar behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
