yamt commented on code in PR #15326:
URL: https://github.com/apache/nuttx/pull/15326#discussion_r1897173909


##########
fs/littlefs/lfs_vfs.c:
##########
@@ -1531,7 +1531,7 @@ static int littlefs_mkdir(FAR struct inode *mountpt, FAR 
const char *relpath,
 
   if (len > 0 && relpath[len - 1] == '/')
     {
-      path = lib_get_pathbuffer();
+      path = lib_get_tempbuffer(PATH_MAX);

Review Comment:
   > i feel it's simpler to make
   > 
   > ```
   > #define lib_get_pathbuffer() lib_get_tempbuffer(PATH_MAX)
   > ```
   > 
   > instead of modifying all callers.
   
   that way we can go back to the fixed-sized allocataion easily if/when this 
change turned out to be a bad idea. :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to