nuttxpr commented on PR #15412: URL: https://github.com/apache/nuttx/pull/15412#issuecomment-2568652549
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements as described. While it provides a summary and mentions testing, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** While it states *what* was added, it omits *why* this change is necessary. What problem does it solve? What use case does it enable? How does it work (implementation details)? Are there any related issues? * **Impact:** The description is very vague. It needs to be more specific. Does this impact *only* the goldfish sensor? Are there any user-facing changes (e.g., new configuration options)? Does this change the build process (new Kconfig options, etc.)? All "Impact" sections require explicit "YES" or "NO" answers, followed by details if "YES". The current response misses all of these details. * **Testing:** "qemu uorb_listener" is insufficient. What exactly was tested? What were the expected results? The requirement explicitly asks for logs *before* and *after* the change to demonstrate the impact and correctness of the modification. What host and target platforms were used for testing? Provide specifics about the OS, architecture, board, and configuration. In short, the PR needs significantly more detail to meet the NuttX requirements. It needs to be more explicit and demonstrate a thorough understanding of the change's impact and provide evidence of proper testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
