nuttxpr commented on PR #15415: URL: https://github.com/apache/nuttx/pull/15415#issuecomment-2568685455
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides some information, it lacks crucial details. Here's why: * **Insufficient Summary:** "remove all spin_lock_irqsave(NULL)" is vague. *Why* was this removal necessary? What problem did it solve? What is `spin_lock_irqsave(NULL)` and why is it problematic? What part of the scheduler code was affected? * **Missing Impact Assessment:** While "sched" is mentioned, a proper impact assessment is missing. Explicitly state NO/YES for *all* impact categories (user, build, hardware, documentation, security, compatibility). Even if the answer is NO, stating it explicitly demonstrates that the impact was considered. The dependency on other PRs is relevant, but doesn't replace the need for a full impact assessment. * **Inadequate Testing:** "ci" is not sufficient. Where is the evidence that this change works? Provide concrete examples of tests run, including *before* and *after* logs as requested. What targets were tested? What build host? Just saying "ci" doesn't prove anything without specific details. The PR needs to be significantly more detailed to meet the requirements. It should clearly explain the rationale for the change, its impact on various aspects of the system, and provide verifiable evidence of testing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
