xiaoxiang781216 commented on code in PR #15425:
URL: https://github.com/apache/nuttx/pull/15425#discussion_r1903450693


##########
arch/x86/include/i486/irq.h:
##########
@@ -293,15 +293,15 @@ static inline irqstate_t up_irq_save(void)
 
 /* Conditionally disable interrupts */
 
-static inline void up_irq_restore(irqstate_t flags)
+static inline_function void up_irq_restore(irqstate_t flags)
 {
   if (up_irq_enabled(flags))
     {
       up_irq_enable();
     }
 }
 
-static inline void system_call3(unsigned int nbr, uintptr_t parm1,
+static inline_function void system_call3(unsigned int nbr, uintptr_t parm1,
                                 uintptr_t parm2, uintptr_t parm3)

Review Comment:
   align



##########
arch/tricore/include/irq.h:
##########
@@ -186,6 +186,13 @@ static inline_function bool up_interrupt_context(void)
 
   return ret;
 }
+
+/****************************************************************************
+ * Name: up_getusrsp
+ ****************************************************************************/
+
+uintptr_t up_getusrsp(void *regs);

Review Comment:
   where the implementation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to