nuttxpr commented on PR #15505: URL: https://github.com/apache/nuttx/pull/15505#issuecomment-2586160788
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No. This PR description lacks crucial information required by the NuttX guidelines. Here's what's missing: * **Summary:** While it links a prior PR, it doesn't explain *what* the regression is. What functionality was broken? How does this PR fix it? What part of the code was changed and how? * **Impact:** The current entry just lists a file path. It needs to explicitly answer all the impact questions (user impact, build impact, hardware impact, documentation, security, compatibility). Use "NO" or "YES" followed by a description if yes. * **Testing:** Linking to a CI issue isn't sufficient. It needs to specify the *local* test setup used (host OS, compiler, target architecture and board) and provide *actual* before/after testing logs demonstrating the fix. Simply pointing to a CI run doesn't show what specific tests were run locally and their results. The author needs to substantially expand this PR description to be accepted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
