eren-terzioglu commented on PR #15434: URL: https://github.com/apache/nuttx/pull/15434#issuecomment-2586534803
> Hi @eren-terzioglu If read the values of the registers (**SYSTEM_PERIP_CLK_EN0_REG and SYSTEM_PERIP_RST_EN0_REG**) using getreg32(), the corresponding bits in the registers may not be correctly set if this operation is not performed. Additionally, during previous internal communications, there was a discussion with Espressif about whether this part of the operation is necessary. It was concluded that clock enabling and resetting are routine operations for peripherals. Other peripherals, such as I2C and SPI, also have similar routine operations. I did not get this, if user enables TIMER_2/3, it will enable related clk source which is needed for that timers but TIMER_1 does not use that clock (clk_1). For that reason I did not get why you see that necessary. If related clk src is needed, code already enables and resets it with `periph_module_enable` like the other implementations (i2c, spi, ...). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
