txy-21 commented on PR #2931: URL: https://github.com/apache/nuttx-apps/pull/2931#issuecomment-2591803408
> I don't think that `apps/testing` is a good place to keep any tests logic. This directory was created for `unity` framework which is intended to use by user code to implement user application tests (TDD), but somehow it happened that more and more apps were migrated there. > > It think that currently almost nothing fits there except Unity, Cmoka and fff. Why not create a new folder like `tests` which will hold all test applications, and leave `testing` for tools that can be used by user code? This directory should be reserved for things like testing frameworks integration and similar things. It's more common in various projects to use `tests` directory to hold test logic, not `testing`. > > Also removing `fff` doesn't seems right. It doesn't mater if its not used by any tests in apps, it still can be used to implement user specific tests. Adding a feature just to remove it a few months later is not ok. Maybe no one uses it, or maybe someone does, who knows? @xiaoxiang781216 The above suggestions mention the configuration of tests and testing folders. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
