pussuw commented on code in PR #15566:
URL: https://github.com/apache/nuttx/pull/15566#discussion_r1918970832


##########
sched/pthread/pthread_condsignal.c:
##########
@@ -68,12 +66,16 @@ int pthread_cond_signal(FAR pthread_cond_t *cond)
     }
   else
     {
-      if (cond->wait_count > 0)
+      nxmutex_lock(&cond->mutex);
+
+      if (atomic_load(&cond->wait_count) > 0)

Review Comment:
   I'll try with atomic_cmpxchg, it would be better if the lock can be avoided



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to