xiaoxiang781216 commented on code in PR #15593: URL: https://github.com/apache/nuttx/pull/15593#discussion_r1922982421
########## arch/arm/src/qemu/qemu_boot.c: ########## @@ -98,6 +107,12 @@ void arm_boot(void) #ifdef CONFIG_SYSLOG_RPMSG syslog_rpmsg_init_early(g_syslog_rpmsg_buf, sizeof(g_syslog_rpmsg_buf)); #endif + +#ifdef CONFIG_ARCH_ARMV7R + /* dont return per armv7-r/arm_head.S design */ + + nx_start(); Review Comment: My suggestion is: either let armv7-r call nx_start in assembly code, or remove nx_start in assemly code in armv7-a arm_head.S. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
