nuttxpr commented on PR #15671: URL: https://github.com/apache/nuttx/pull/15671#issuecomment-2609816452
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary of the *what*, it lacks crucial details about *why* these changes are necessary. The impact section is too brief and doesn't address all the points required. Critically, there is no testing information provided whatsoever. Here's a breakdown of what's missing: * **Summary:** Needs to explain the rationale behind removing spaces and adding tabs. Are these changes for stylistic consistency? Do they fix a bug? Improve readability? A related issue number would also be helpful if one exists. * **Impact:** While the changes might seem minor, it's important to explicitly state "NO" for each impact category (or "YES" if applicable and explain). Simply writing "none" is insufficient. For example: * Impact on user: NO * Impact on build: NO (assuming no changes to the build process itself) * Impact on hardware: NO * Impact on documentation: Possibly YES if coding style guidelines are updated. * Impact on security: NO * Impact on compatibility: NO (unless the change affects how Kconfig files are parsed by older tools) * **Testing:** Completely missing. Needs to specify the host and target environments where the changes were tested. Must include logs demonstrating the behavior before and after the change. Even for seemingly trivial changes, demonstrating that the build still works and the configuration system behaves as expected is essential. Without these details, it's difficult to properly review the PR and assess its suitability for inclusion in NuttX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
