xiaoxiang781216 commented on code in PR #15766: URL: https://github.com/apache/nuttx/pull/15766#discussion_r1943962377
########## arch/arm/src/armv6-m/arm_ramvec_attach.c: ########## @@ -31,18 +31,11 @@ #include <nuttx/irq.h> #include <nuttx/arch.h> -#include <nuttx/spinlock.h> #include "ram_vectors.h" #ifdef CONFIG_ARCH_RAMVECTORS -/**************************************************************************** - * Private Data - ****************************************************************************/ - -static spinlock_t g_ramvec_lock = SP_UNLOCKED; Review Comment: let's keep the change in armv6-m/armv7-m/armv8-m/armv7-a/armv7-r/armv8-r ########## arch/sim/src/sim/sim_usbdev.c: ########## @@ -39,7 +39,6 @@ #include <nuttx/arch.h> #include <nuttx/kmalloc.h> -#include <nuttx/spinlock.h> Review Comment: let's continue remove the critical section in arch/sim ########## arch/x86_64/src/intel64/intel64_oneshot.c: ########## @@ -29,6 +29,7 @@ #include <sys/types.h> #include <stdint.h> #include <stdbool.h> +#include <sched.h> Review Comment: keep all x86_64 change too ########## arch/tricore/src/common/tricore_systimer.c: ########## @@ -24,7 +24,7 @@ * Included Files ****************************************************************************/ -#include <nuttx/spinlock.h> +#include <nuttx/irq.h> Review Comment: let's continue tricore change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
