nuttxpr commented on PR #15806: URL: https://github.com/apache/nuttx/pull/15806#issuecomment-2648787755
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it addresses some aspects, it lacks crucial information. Here's what's missing: * **Summary:** The summary is insufficient. It mentions *what* changed (removing spaces, adding tabs), but not *why*. What problem did the spaces cause? Why are tabs preferable? What specific sensors driver Kconfig file was modified? This section should clearly articulate the *reason* for the change, not just the change itself. It should also include related issue references if applicable. * **Impact:** While it mentions user and build impact (correctly stating no change), it omits the other impact categories. Specifically, it needs to address: * **Hardware:** Even if the answer is NO, it needs to be explicitly stated. * **Documentation:** Does this change require documentation updates? Likely not, but it needs to be stated. * **Security:** Explicitly state NO. * **Compatibility:** Explicitly state NO. * **Testing:** The "local" reference is inadequate. Provide specifics about the build host (OS, CPU, compiler) and target (architecture, board, configuration). Also, "testing logs" are missing. What tests were run to verify this change? Even for simple formatting changes, there should be some evidence that the change didn't inadvertently break something. Show the relevant portions of the Kconfig output before and after the change, or describe the manual verification steps. In short, the PR needs more context and justification for the changes, and thorough testing information. Just changing whitespace without a clear reason and without demonstrating that it doesn't break anything is not sufficient for a good PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
