simbit18 commented on PR #2993: URL: https://github.com/apache/nuttx-apps/pull/2993#issuecomment-2659388692
Hi @cederom this PR https://github.com/apache/nuttx/pull/14693 the sim:quickjs build was only with make the reference package was this quickjs-2020-11-08.tar.xz (QUICKJS_VERSION and VERSION were the same) QUICKJS_VERSION is used in the construction of the url url -> https://bellard.org/quickjs/quickjs-$(QUICKJS_VERSION).tar.xz After this https://github.com/apache/nuttx/pull/14693 and PR https://github.com/apache/nuttx-apps/pull/2827 the sim:quickjs build was moved to cmake with reference to the master package of the quickjs repository also modifying the patch. url -> https://github.com/bellard/quickjs/archive/refs/heads/master.zip So sim:quickjs is built correctly on Ubuntu with Docker because cmake uses different sources. Obviously if we go through the build with make it fails !!! In fact here is what happens on our NuttX mirror macOS (sim-03) uses Make ``` ==================================================================================== Configuration/Tool: sim/quickjs 2025-02-14 02:41:31 ------------------------------------------------------------------------------------ Cleaning... Configuring... Building NuttX... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 0 0 0 0 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 734k 100 734k 0 0 894k 0 --:--:-- --:--:-- --:--:-- 895k make[3]: *** [quickjs] Error 1 make[3]: Target `context' not remade because of errors. make[2]: *** [/Users/runner/work/nuttx/nuttx/sources/apps/interpreters/quickjs_context] Error 2 make[2]: Target `context_all' not remade because of errors. make[1]: *** [context] Error 2 make: *** [/Users/runner/work/nuttx/nuttx/sources/apps/.context] Error 2 make: Target `all' not remade because of errors. /Users/runner/work/nuttx/nuttx/sources/nuttx/tools/testbuild.sh: line 385: /Users/runner/work/nuttx/nuttx/sources/nuttx/../nuttx/nuttx.manifest: No such file or directory [1/1] Normalize sim/quickjs ==================================================================================== ``` As Alan has rightly as pointed out it is necessary to have a reference TAG. With a new PR I will fix Cmakefile and Make to avoid future breakage. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
