raiden00pl commented on code in PR #15828:
URL: https://github.com/apache/nuttx/pull/15828#discussion_r1959330075
##########
include/nuttx/wireless/ioctl.h:
##########
@@ -60,13 +60,31 @@
/* output power (in dBm) */
#define WLIOC_GETTXPOWER _WLCIOC(0x0006) /* arg: Pointer to int32_t, */
/* output power (in dBm) */
+#define WLIOC_SETBANDWIDTH _WLCIOC(0x0007) /* arg: Pointer to uint32_t, */
+ /* bandwidth in Hz */
+#define WLIOC_GETBANDWIDTH _WLCIOC(0x0008) /* arg: Pointer to uint32_t, */
+ /* bandwidth in Hz */
+#define WLIOC_SETSPREAD _WLCIOC(0x0009) /* arg: Pointer to uint8_t, */
+ /* spread factor */
+#define WLIOC_GETSPREAD _WLCIOC(0x000a) /* arg: Pointer to uint8_t, */
+ /* spread factor */
+#define WLIOC_GETSNR _WLCIOC(0x000b) /* arg: Pointer to int8_t, */
+ /* signal to noise ratio */
+#define WLIOC_SETPRLEN _WLCIOC(0x000c) /* arg: uint16_t, */
+ /* preamble length */
+#define WLIOC_GETPRLEN _WLCIOC(0x000d) /* arg: Pointer to uint16_t, */
+ /* preamble length */
+#define WLIOC_SETMOD _WLCIOC(0x000e) /* arg: enum, */
+ /* modulation type */
+#define WLIOC_GETMOD _WLCIOC(0x000f) /* arg: char[10] pointer, */
+ /* modulation type */
Review Comment:
> If desired I could also convert the SX127X commands to general WLIOC
commands? That way any module can use them since there would be some sharing
between it and the rn2xx3?
Yes, I think this is the correct way. When I created the sx127x driver there
was no other chips for Lora available, now there is much more chips supporting
Lora, so some of these should be moved to common ioctl.
Ideally, we should be able to use different Lora chips with the same code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
