tmedicci commented on PR #15821:
URL: https://github.com/apache/nuttx/pull/15821#issuecomment-2672365187

   > The 1st patchset missed the change to 
`arch/xtensa/src/esp32/esp32_cpustart.c`. I have updated it in latest patch, 
this will make ESP32 SMP can boot, but still ostest will fail at sighand test 
if enable the config.
   > 
   > And also change `XTENSA_PERCPU_TCB_IN_MISC0` to:
   > 
   > ```
   >    default n if ARCH_CHIP_ESP32
   >    default y
   > ```
   > 
   
   Yes, I saw it. I tested with it.
   
   > To investigate why ESP32 SMP does not work is not easy, it needs long time 
and comprehensive understanding of ESP32 chip. So I suggest to commit with 
current change, which will benefit all other chips, and leave a bug to 
investigate later.
   
   I'm not comfortable with merging it leaving ESP32 behind... This is an 
architecture optimization that doesn't work for a chip. The fact that it 
doesn't work for a known case of ESP32 may be related to some flaw in the 
design (maybe it isn't failing on other use cases because we are not testing it 
enough).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to