nuttxpr commented on PR #15929: URL: https://github.com/apache/nuttx/pull/15929#issuecomment-2693945087
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a decent summary and explains the impact, it lacks several key elements: * **Summary:** Missing related issue references. While it mentions a related commit hash, a proper issue link is preferred for traceability. It needs to be more specific about *what* functional part of the code is being changed (e.g., the RISC-V timer driver, a specific file). * **Impact:** While it mentions the impact on real RISC-V hardware, it needs to explicitly answer all the YES/NO questions: * **Is new feature added?** NO * **Is existing feature changed?** YES (clock drift fix, timer implementation change) * **Impact on user:** Possibly YES if user code relies on precise timing, but this needs clarification. * **Impact on build:** Likely NO, but needs confirmation. * **Impact on hardware:** YES (RISC-V architectures) - Be more specific which boards are affected within the RISC-V architecture. * **Impact on documentation:** Likely YES if the timer behavior has changed, this needs an explicit statement and confirmation if documentation updates are included. * **Impact on security:** NO (needs explicit statement) * **Impact on compatibility:** Potentially YES, depending on the nature of the fix. This needs clarification. * **Testing:** Severely lacking. "MPFS250T hardware" is insufficient. Needs: * **Build Host details:** OS, CPU architecture, compiler version used for the build. * **Target details:** Specific RISC-V architecture and board configuration used (e.g., `riscv:mpfs_icicle`). * **Crucially, it's missing the "before" and "after" testing logs.** These logs are essential to demonstrate the fix and justify the PR. Quantify the clock drift before and its absence after. What tests were run? In short, the PR needs more detail and, most importantly, the testing logs to demonstrate the effectiveness of the proposed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
