xiaoxiang781216 commented on PR #15931: URL: https://github.com/apache/nuttx/pull/15931#issuecomment-2705329541
> @cederom basically all the requested changes were fixed. But I agree this PR could have high risk to break existing system and the author didn't test on real hardware. no, @yangsong8-a1 already test on two different real devices and sim. > @acassis this is second time recently you have merged PR despite unresolved discussions and potentially breaking changes :-( it depends on how do you define the breaking change. This patch remove the internal buffer to avoid one memory copy and therefore remove the unused buffer size option from Kconfig. The end user could still keep these config in their defconfig, but witout any impact. So, before you said something is breaking, please really understand the code change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
