nuttxpr commented on PR #16144: URL: https://github.com/apache/nuttx/pull/16144#issuecomment-2781642330
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the basic requirements, but it lacks crucial details. While it adheres to the structure, the content is too brief to be truly informative. Here's why it's insufficient and what's missing: * **Summary:** Saying "Add release notes for 12.9.0 release" is not descriptive enough. What are the key highlights of this release? Mention significant bug fixes, new features, or improvements. Even a concise bullet list would be better. * **Impact:** Just saying "RELEASE" doesn't convey the full impact. While a release inherently implies changes, the PR needs to specify *what* changed. Are there breaking changes? New dependencies? Deprecations? * **Testing:** "CI" is insufficient. While CI passing is important, the PR needs to show *specific* tests relevant to the changes introduced by the release notes. If the release notes mention a new feature, show tests verifying that feature. If they mention a bug fix, show tests demonstrating the fix. "Before" and "after" logs are expected, especially for a release. What was the behavior before the changes reflected in the release notes, and how has it changed? In short, the PR needs more context. It needs to explain *what* is being released, *how* it affects users, and provide *evidence* that the release notes accurately reflect the changes. Just stating that release notes are added doesn't fulfill the requirement of demonstrating that the changes described are valid and tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
