nuttxpr commented on PR #16191: URL: https://github.com/apache/nuttx/pull/16191#issuecomment-2796521582
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it addresses some sections, it lacks crucial details. Here's a breakdown: * **Insufficient Summary:** "fix Relative file path does not match actual file" is a title, not a summary. It needs to explain *why* the path was incorrect, *what* part of the code was changed to fix it, and *how* the fix works. An issue number should also be linked if one exists. * **Missing Testing Details:** "local" is not sufficient. Specify the Build Host OS, CPU, compiler, and the Target architecture, board, and configuration used for testing. Crucially, the testing logs *before* and *after* the change are missing. These logs demonstrate the problem existed and is now resolved. **To make this PR compliant, the author needs to add the following:** * **Expanded Summary:** Explain the root cause of the file path mismatch, the specific files/functions modified, and the logic of the correction. Include a related NuttX issue link if applicable. * **Detailed Testing Information:** Specify the Build Host and Target environments completely. Provide actual log output demonstrating the issue before the change and the corrected behavior after the change. Even if the output is simple, include it. For example: ``` Testing logs before change: ``` `ls /path/to/file` returns "No such file or directory" ``` Testing logs after change: ``` `ls /path/to/file` returns filename `cat /path/to/file` returns file contents (or a summary of expected contents) By providing these missing details, the PR will meet the NuttX requirements and enable proper review and validation of the proposed changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
