acassis commented on PR #3057: URL: https://github.com/apache/nuttx-apps/pull/3057#issuecomment-2803139182
@cederom @lupyuen @Donny9 comparing both file with meld I can see they are basically the same code: ``` alan@dev:~/nuttxspace/apps$ meld nshlib/nsh_ddcmd.c system/dd/dd_main.c ``` But I think system/dd will evolve to be more complete and compatible with Linux/Unix over the time. For example, nsh_ddcmd.c has CONFIG_NSH_CMDOPT_DD_STATS that doesn't exist in system/dd, so it rings a bell that system/dd is more focused on compatibility vs code size. I think that CONFIG_NSH_CMDOPT_DD_STATS could be renamed to CONFIG_SYSTEM_DD_MINIMUM and included in other parts there that aren't essential for a simple dd command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
