nuttxpr commented on PR #16217: URL: https://github.com/apache/nuttx/pull/16217#issuecomment-2805483571
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR description does not fully meet the NuttX requirements. Here's why and how to fix it: * **Summary:** While it states *what* was changed, it lacks crucial details: * **Why?** What problem does this solve? Why is this driver needed? (e.g., "Enables control of LEDs connected to a KTD2052 driver, allowing for..." or "Adds support for a commonly used LED driver, expanding hardware compatibility.") * **How?** "Driver implementation" is too vague. Briefly explain the mechanism. (e.g., "Uses I2C to communicate with the KTD2052, setting brightness levels through registers...") * **Issues:** Are there any related NuttX or NuttX Apps issues this addresses? Even if not, explicitly stating "N/A" is helpful. * **Impact:** While some impacts are addressed, others are missing or incomplete: * **New Feature:** Explicitly say "YES". * **User Impact:** Even if the answer is NO, briefly explain why. (e.g., "NO, this adds a new driver and does not affect existing LED functionality.") * **Build Impact:** YES - You added a Kconfig option. Describe how the build process is affected. (e.g., "YES, a new Kconfig option `CONFIG_LED_KTD2052` enables the driver.") * **Hardware Impact:** Be specific about which architectures and boards are supported. (e.g., "YES, supports the KTD2052 on [architecture] platforms, tested on a custom board.") * **Documentation:** If no documentation was added, state that and why. (e.g., "NO, documentation will be added in a follow-up commit.") or "YES, a README.md file describing the driver usage has been added." * **Security, Compatibility:** Explicitly state "NO" (if applicable) with a brief explanation. (e.g., "NO, this driver does not introduce any new security concerns." / "NO, this is a new driver and maintains backward compatibility.") * **Testing:** Severely lacking detail. * **Build Host:** Provide specifics. (e.g., "Linux Ubuntu 22.04, x86_64, GCC 11.2") * **Target:** Provide specific architecture, board, and configuration. (e.g., "ARM Cortex-M4, Custom KTD2052 board, `stm32f4discovery:nsh` config") * **Logs:** The "before" logs might not be relevant for a new driver, but "after" logs demonstrating the driver's functionality are essential. Include examples showing successful LED control. If the logs are extensive, consider attaching a file instead of pasting them directly. **Example of Improved PR Description:** ``` This commit adds support for the KTD2052 LED driver chip, expanding hardware compatibility for LED control within NuttX. ## Summary This change adds a driver for the KTD2052 LED driver chip, allowing users to control LEDs connected to this chip. The driver communicates with the KTD2052 via I2C, setting brightness levels through specific registers. This addresses the need to support this commonly used LED driver chip. Related NuttX Issue: N/A Related NuttX Apps Issue/PR: N/A ## Impact * New feature added? YES * Impact on user: NO, this adds a new driver and does not affect existing LED functionality. Users wishing to use this new driver will need to configure their .config file appropriately. * Impact on build: YES, a new Kconfig option `CONFIG_LED_KTD2052` enables the driver. * Impact on hardware: YES, supports the KTD2052 on ARM platforms, tested on a custom KTD2052 board. * Impact on documentation: NO, documentation will be added in a follow-up commit. * Impact on security: NO, this driver does not introduce any new security concerns. * Impact on compatibility: NO, this is a new driver and maintains backward compatibility. ## Testing I confirm that changes are verified on a local setup and work as intended: * Build Host(s): Linux Ubuntu 22.04, x86_64, GCC 11.2 * Target(s): ARM Cortex-M4, Custom KTD2052 board, `stm32f4discovery:nsh` config (adapted for the custom board) Testing logs after change: ``` nsh> ktd2052_test # Example test application Initializing KTD2052... Success! Setting LED 1 to 50% brightness... Success! Setting LED 2 to 100% brightness... Success! ... ``` ``` By providing more detail and addressing all the required points, your PR will be much easier to review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
