nuttxpr commented on PR #16206: URL: https://github.com/apache/nuttx/pull/16206#issuecomment-2803108877
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and some testing information, it lacks crucial details. Here's what's missing: * **Summary:** Needs to be more explicit. * *Why* were these options missed? Was it an oversight, a dependency issue, etc.? * *What* functional part of the code is changed? Be specific – mention the Kconfig files modified. * *How* does it work? Does it just add the options? Are there any dependencies or interactions with other configurations? A before/after snippet of the Kconfig would be helpful. * Link a related NuttX issue if one exists. * **Impact:** Needs significantly more detail. Simply stating "Allows selecting USART6" is insufficient. * *Is new feature added?* YES * *Impact on user?* YES - Users can now configure USART6. Briefly explain how they would do this (e.g., menuconfig path). * *Impact on build?* Potentially YES if there are dependencies. Explain any potential build changes. * *Impact on hardware?* YES. Specify it affects the STM32H5 architecture. * *Impact on documentation?* Potentially YES. If this requires documentation updates, mention whether they're included or if a separate PR will follow. * *Impact on security, compatibility?* Explicitly state NO if there's no impact, along with a brief justification if necessary (e.g., "No security impact as this only adds configuration options."). * **Testing:** Needs more information. * *Build Host(s):* Provide details about your build environment (OS, CPU architecture, compiler version). * *Target(s):* "Custom board" is too vague. Provide more details about the board configuration. While mentioning the chip is helpful, the board configuration is essential for reproducibility. * *Testing logs:* You *must* include logs demonstrating the functionality before and after the change. Show how the USART6 configuration affects the build and, ideally, demonstrate basic USART6 operation on the target hardware. "Works as intended" is not sufficient proof. The reference to the original PR is useful context but doesn't replace the need for complete information in *this* PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
