nuttxpr commented on PR #16225: URL: https://github.com/apache/nuttx/pull/16225#issuecomment-2808830399
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and testing information, it lacks crucial details. Here's a breakdown of what's missing: * **Summary:** Lacks details on *what* functional part of the code is changed and *how* the change works. Saying "makes units compatible" is vague. Which units? How are they made compatible? The reference to the tools PR (XXX) needs a proper link. * **Impact:** The impact section is severely incomplete. It only addresses user impact. It needs to address *all* other impact points: * **Is new feature added? Is existing feature changed?** (Yes, existing feature changed) * **Impact on build:** NO/YES and explanation. * **Impact on hardware:** NO/YES and explanation. * **Impact on documentation:** NO/YES and explanation (critical since the user impact mentions changes are needed). * **Impact on security:** NO/YES and explanation. * **Impact on compatibility:** NO/YES and explanation. * **Anything else to consider?** * **Testing:** While testing logs are included placeholders, the build host and target details are missing. Need to specify the OS, CPU, compiler for the host, and the architecture and board configuration for the target. Also, simply stating "CAN message still arrive properly" is insufficient. More detailed logs demonstrating the bitrate change are necessary. For instance, logs from `slcan` showing the configured bitrate would be beneficial. In short, the PR needs significant expansion to meet the NuttX requirements. It needs to be more specific and comprehensive in all sections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
