xiaoxiang781216 commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2056134293
########## include/nuttx/semaphore.h: ########## @@ -184,9 +184,17 @@ int nxsem_destroy(FAR sem_t *sem); * ****************************************************************************/ -int nxsem_wait(FAR sem_t *sem); int nxsem_wait_slow(FAR sem_t *sem); +#if !defined(CONFIG_SMP) && defined(CONFIG_BUILD_FLAT) +static inline int nxsem_wait(FAR sem_t *sem) Review Comment: do you make some benchmark? The fast path is still better even in flat/up case from our test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
