pussuw commented on code in PR #16194:
URL: https://github.com/apache/nuttx/pull/16194#discussion_r2058935926
##########
sched/semaphore/sem_recover.c:
##########
@@ -100,7 +101,39 @@ void nxsem_recover(FAR struct tcb_s *tcb)
* place.
*/
- atomic_fetch_add(NXSEM_COUNT(sem), 1);
+ if (NXSEM_IS_MUTEX(sem))
+ {
+ FAR dq_entry_t *wtcb;
+ uint32_t mholder;
+ uint32_t blocks_mask = ~NXSEM_MBLOCKS_BIT;
+
+ /* The TID of the mutex holder is correct but we need to
+ * update the blocking bit. Count the remaining tcbs in the
+ * blocking list (ignoring the one that is being cancelled).
+ */
+
+ for (wtcb = dq_peek(SEM_WAITLIST(sem)); wtcb; wtcb = dq_next(wtcb))
Review Comment:
In this case tcb is waiting for this mutex. The only thing that needs to be
done is to remove it from the SEM_WAITLIST. If the waitlist becomes empty, then
clear block mask ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
