jlaitine commented on code in PR #16194: URL: https://github.com/apache/nuttx/pull/16194#discussion_r2059569009
########## libs/libc/semaphore/sem_init.c: ########## @@ -62,15 +62,15 @@ * ****************************************************************************/ -int nxsem_init(FAR sem_t *sem, int pshared, unsigned int value) +int nxsem_init(FAR sem_t *sem, int pshared, int32_t value) Review Comment: Yes, and I had already forgotten this; I believe changing it is fine since it is anyhow nuttx internal interface, and initializing a 32-bit value (both counter and holder are 32 bits nowdays). But, it probably should be uint32_t; it would make no sense to initialize a counting semaphore with a negative value... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
