nuttxpr commented on PR #16267: URL: https://github.com/apache/nuttx/pull/16267#issuecomment-2832000675
[**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) No, this PR does not fully meet the NuttX requirements. While it provides a summary and mentions testing, it lacks crucial details. Here's what's missing: * **Summary:** Lacks detail. *Why* is this change necessary? What problem does it solve? *What* functional part of the code changed (e.g., specific files/functions)? *How* does the custom height/width setting work (e.g., configuration options, API calls)? Issue references are missing. * **Impact:** While it mentions customization, it's insufficient. It needs explicit YES/NO answers for *all* impact categories, followed by descriptions where applicable. For example, does it impact the build process? Documentation? Even if the answer is NO, state it explicitly. * **Testing:** Severely lacking. It mentions the resolution tested on but provides no actual logs. It also omits the build host details. What OS, compiler, etc., was used for the build? What target architecture and board configuration were used? "Tested" is meaningless without evidence; provide the logs. The PR needs significant revision to meet the requirements. It must provide specific details for each section, including issue references, clear descriptions of the changes, and thorough testing information, including logs demonstrating the functionality before and after the change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
