raiden00pl commented on code in PR #16293:
URL: https://github.com/apache/nuttx/pull/16293#discussion_r2069963907
##########
arch/arm/src/stm32f0l0g0/Kconfig:
##########
@@ -531,6 +531,86 @@ config ARCH_CHIP_STM32G071RB
select STM32F0L0G0_STM32G0
depends on ARCH_CHIP_STM32G0
+config ARCH_CHIP_STM32G0B1KB
Review Comment:
please split changes to `/arch` and `/boards` into separate commits.
Something like this:
* /arch/stm32f0l0g0: add stm32g0bXXX support
* /boards/stm32f0l0g0: Add Nucleo G0B1RE support
##########
arch/arm/src/stm32f0l0g0/stm32_crypto.c:
##########
@@ -79,7 +79,7 @@ static int stm32_newsession(uint32_t *sid, struct cryptoini
*cri)
*sid = g_stm32_sesnum++;
break;
- default :
+ default:
Review Comment:
please move this change to a separate commit
##########
arch/arm/src/stm32f0l0g0/stm32_serial_v1.c:
##########
@@ -2320,25 +2320,25 @@ static void stm32serial_pmnotify(struct pm_callback_s
*cb, int domain,
{
switch (pmstate)
{
- case(PM_NORMAL):
Review Comment:
please move serial related changes to a separate commit
##########
arch/arm/include/stm32f0l0g0/chip.h:
##########
@@ -281,6 +281,39 @@
# define STM32_NCAP 0 /* No Capacitive sensing channels */
# define STM32_NPORTS 6 /* Six GPIO ports, GPIOA-F */
+#elif defined(CONFIG_ARCH_CHIP_STM32G0B1KB) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1CB) || \
+ defined(CONFIG_ARCH_CHIP_STM32G0B1RB) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1MB) || \
+ defined(CONFIG_ARCH_CHIP_STM32G0B1VB) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1KC) || \
+ defined(CONFIG_ARCH_CHIP_STM32G0B1CC) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1RC) || \
+ defined(CONFIG_ARCH_CHIP_STM32G0B1MC) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1VC) || \
+ defined(CONFIG_ARCH_CHIP_STM32G0B1KE) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1CE) || \
+ defined(CONFIG_ARCH_CHIP_STM32G0B1RE) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1NE) || \
+ defined(CONFIG_ARCH_CHIP_STM32G0B1ME) ||
defined(CONFIG_ARCH_CHIP_STM32G0B1VE)
+
+# define STM32_NATIM 1 /* One advanced timer TIM1 */
// Checked
Review Comment:
remove c++ comments
##########
boards/Kconfig:
##########
@@ -3552,6 +3562,7 @@ config ARCH_BOARD
default "stm32g071b-disco" if ARCH_BOARD_STM32G071B_DISCO
default "nucleo-g070rb" if ARCH_BOARD_NUCLEO_G070RB
default "nucleo-g071rb" if ARCH_BOARD_NUCLEO_G071RB
+ default "nucleo-g0b1re" if
ARCH_BOARD_NUCLEO_G0B1RE
Review Comment:
please fix this indentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
