acassis commented on code in PR #3068:
URL: https://github.com/apache/nuttx-apps/pull/3068#discussion_r2075411412
##########
boot/nxboot/Kconfig:
##########
@@ -92,6 +103,10 @@ config NXBOOT_PREVENT_DOWNGRADE
WARNING: NXboot currently implements preferences only for
MAJOR.MINOR.PATCH and ignores prerelease.
+config NXBOOT_PRINTF_PROGRESS
+ bool "Enable progress messages to be sent to STDOUT"
+ default n
Review Comment:
I think a progress percentage (or even a progress bar), is something
expected to exist by default (y), maybe the option should be here to disable it.
##########
boot/nxboot/Kconfig:
##########
@@ -64,6 +64,17 @@ config NXBOOT_BOOTLOADER
if NXBOOT_BOOTLOADER
+config NXBOOT_COPY_TO_RAM
+ bool "Copy bootable image to RAM before calling board boot-image
function"
+ default n
+
+config NXBOOT_RAMSTART
+ hex "Start address in RAM that the application is to be loaded"
+ default 0x0
+ depends on NXBOOT_COPY_TO_RAM
+ ---help---
+ This will be board specific.
Review Comment:
Please improve this help, i.e. is there some recommend position in the heap?
Maybe including suggestions how to reserve the space in the linker script to
avoid other applications to use, etc
##########
boot/nxboot/Kconfig:
##########
@@ -64,6 +64,17 @@ config NXBOOT_BOOTLOADER
if NXBOOT_BOOTLOADER
+config NXBOOT_COPY_TO_RAM
+ bool "Copy bootable image to RAM before calling board boot-image
function"
+ default n
Review Comment:
Please include a ---help--- explaining when and why to use it, etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
