sumpfralle commented on code in PR #16319:
URL: https://github.com/apache/nuttx/pull/16319#discussion_r2079236505
##########
libs/libc/stream/lib_blkoutstream.c:
##########
@@ -153,15 +153,15 @@ static ssize_t blkoutstream_puts(FAR struct
lib_sostream_s *self,
if (offset > 0)
{
- size_t copyin = offset + remain > sectorsize ?
Review Comment:
In general I agree with your approach of keeping "traditional" names for
variables or functions, even if they conflict with spelling due to a shortage
of characters.
In the specific case of `copyin`, I refined your search suggestion a bit in
order to filter out all occurrences of "COPYING". This reduced the number of
occurrences in the linux kernel source from 2.7k [down to
27](https://github.com/search?q=repo%3Atorvalds%2Flinux+%2Fcopyin%5Cb%2F&type=code)
with only two occurrences in a header file (i.e. "public").
Thus, I would argue, that "copyin" is not in widespread use. I suggest to
"fix" the spelling here (as done in the PR).
I am aware, that the name "copyin" can be understood as a good choice based
on the [nuttx coding standard for variable
names](https://nuttx.apache.org/docs/latest/contributing/coding_style.html#parameters-and-local-variables)
("short" and "minimal use of underscore"). I do not feel entitled to judge
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
