pussuw commented on code in PR #16344: URL: https://github.com/apache/nuttx/pull/16344#discussion_r2081287466
########## arch/arm/src/armv7-a/arm_addrenv.c: ########## @@ -238,14 +182,27 @@ int up_addrenv_create(size_t textsize, size_t datasize, size_t heapsize, memset(addrenv, 0, sizeof(arch_addrenv_t)); + tablesize = PGTABLE_SIZE * sizeof(uintptr_t); + addrenv->l1table = kmm_memalign(tablesize, tablesize); Review Comment: As a semantic the page tables should be allocated from the page pool. I don't understand why you are allocating so much memory for the L1 table anyway ? 1 page for L1 is enough to map the full 32-bit virtual address space ? https://developer.arm.com/documentation/den0013/d/The-Memory-Management-Unit/First-level-address-translation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
