pussuw commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2084978945


##########
fs/vfs/fs_close.c:
##########
@@ -134,46 +143,84 @@ int file_close_without_clear(FAR struct file *filep)
 
           inode_release(inode);

Review Comment:
   Can someone tell me where the inode reference to this release should be 
taken ? I could not find it anywhere in the old code. I fixed the pseudofile 
system by adding +1 to the inode refs when creating a new pseudofile, but it 
seems other drivers don't take the reference.
   
   Am I supposed to take the reference at a higher level ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to