xiaoxiang781216 commented on a change in pull request #1506:
URL: https://github.com/apache/incubator-nuttx/pull/1506#discussion_r465435286
##########
File path: include/nuttx/serial/tioctl.h
##########
@@ -190,6 +191,7 @@
# define SER_SINGLEWIRE_PULL_DISABLE (0 << SER_SINGLEWIRE_PULL_SHIFT) /*
Float RX/TX Line */
# define SER_SINGLEWIRE_PULLUP (1 << SER_SINGLEWIRE_PULL_SHIFT) /*
Enable Pull up the RX/TX Line */
# define SER_SINGLEWIRE_PULLDOWN (2 << SER_SINGLEWIRE_PULL_SHIFT) /*
Enable Pull down the RX/TX Line */
+# define SER_SINGLEWIRE_PUSHPULL (1 << 3) /* Use
PUSH/PULL not Open Drain with Single wire */
Review comment:
PUSHPULL normally mean drive the line with high/low voltage, I can't
understand why it need ored with PULLUP/PULLDOWN? What's mean if the caller
pass PUSHPULL | PULLUP?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
