xiaoxiang781216 commented on code in PR #16363: URL: https://github.com/apache/nuttx/pull/16363#discussion_r2086845151
########## arch/arm/src/rp23xx/rp23xx_timerisr.c: ########## @@ -107,10 +110,14 @@ void up_timer_initialize(void) regval |= (NVIC_SYSH_PRIORITY_DEFAULT << NVIC_SYSH_PRIORITY_PR15_SHIFT); putreg32(regval, NVIC_SYSH12_15_PRIORITY); +#if defined(CONFIG_ARMV8M_SYSTICK) && defined(CONFIG_TIMER_ARCH) Review Comment: ```suggestion #ifdef CONFIG_RP23XX_SYSTIMER_SYSTICK ``` ########## arch/arm/src/rp23xx/rp23xx_timerisr.c: ########## @@ -74,14 +76,15 @@ * of the systems. * ****************************************************************************/ - +#if !defined(CONFIG_ARMV8M_SYSTICK) && !defined(CONFIG_TIMER_ARCH) Review Comment: ```suggestion #ifndef CONFIG_RP23XX_SYSTIMER_SYSTICK ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
