xiaoxiang781216 commented on code in PR #16361:
URL: https://github.com/apache/nuttx/pull/16361#discussion_r2094179941
##########
fs/vfs/fs_ioctl.c:
##########
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
case FIOC_SETTAG_FDSAN:
- filep->f_tag_fdsan = *(FAR uint64_t *)arg;
- ret = OK;
- break;
-
case FIOC_GETTAG_FDSAN:
- *(FAR uint64_t *)arg = filep->f_tag_fdsan;
- ret = OK;
- break;
-#endif
-
-#ifdef CONFIG_FDCHECK
case FIOC_SETTAG_FDCHECK:
- filep->f_tag_fdcheck = *(FAR uint8_t *)arg;
- ret = OK;
- break;
-
case FIOC_GETTAG_FDCHECK:
- *(FAR uint8_t *)arg = filep->f_tag_fdcheck;
- ret = OK;
+ ret = nx_fcntl(fd, req, arg);
Review Comment:
if all check want to move fcntl, we should move FIOC_xxxxx_xxCHECK to
fcntl.h and rename to F_xxxx_xxCHECK, and don't need forward the call from
ioctl to fcntl.
##########
fs/vfs/fs_ioctl.c:
##########
@@ -135,29 +135,12 @@ static int file_vioctl(FAR struct file *filep, int req,
va_list ap)
}
break;
-#ifdef CONFIG_FDSAN
Review Comment:
why remove the check
##########
include/nuttx/fs/ioctl.h:
##########
@@ -197,8 +197,6 @@
* configuration
* OUT: None
*/
-
-#ifdef CONFIG_FDSAN
Review Comment:
why remove the check
##########
fs/procfs/fs_procfsproc.c:
##########
@@ -1325,9 +1325,10 @@ static ssize_t proc_groupfd(FAR struct proc_file_s
*procfile,
if (linesize < STATUS_LINELEN)
{
#if CONFIG_FS_BACKTRACE > 0
+ struct fd *fd = fdlist_fdget(&group->tg_fdlist, i);
Review Comment:
add FAR
##########
include/nuttx/fs/ioctl.h:
##########
@@ -208,9 +206,6 @@
* Pointer to file tag
* OUT: None
*/
-#endif
-
-#ifdef CONFIG_FDCHECK
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
