xiaoxiang781216 commented on PR #16499: URL: https://github.com/apache/nuttx/pull/16499#issuecomment-2957928622
> Why are the original patches, _which we tested to be working correctly_, partially re-written in this PR, instead of pointing out if there were errors in those in the closed PR? > > I completely disagree with this approach. Sorry to intervene, but _YOU CAN'T DO IT LIKE THIS_. > > Please: > > 1. Please re-open the previous PR > it's closed by @pussuw , we are asking @pussuw giving @Donny9 to update that patch before creating a new one, bu @pussuw suggest us to create a new one. > 2. If there are _bugs_ or _architectural issues_ with that one, please point them out > Most comments are fixed in this patch, if you really want I can repeat all comments in that pr again. > 3. Integrate that PR, it already went through a lengthy review, and we invested a lot of time in testing and reviewing that one in our organization(s) > We also take huge time to review, refine and test @pussuw 's work, actually several bugs, uncompleted implementation and better approach update in this pr. > 4. If any bugs are found later * add new patches to fix them * > But why not fix all found issues before merging it? > > This current process makes no sense to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
