xiaoxiang781216 commented on code in PR #16512: URL: https://github.com/apache/nuttx/pull/16512#discussion_r2142387166
########## drivers/segger/segger.c: ########## @@ -0,0 +1,38 @@ +/**************************************************************************** + * drivers/segger/segger.c + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/spinlock.h> + +/**************************************************************************** + * Public Data + ****************************************************************************/ + +spinlock_t g_segger_lock = SP_UNLOCKED; +ptrdiff_t g_segger_offset = PTRDIFF_MAX; Review Comment: we are using segger RTT protocol over shared memory for two core log/trace: one is NuttX another Linux/Windows. But the base address of shared memory can only be known at runtime, so we change SEGGER_RTT_UNCACHED_OFF from macro to global variable, and update to the correct g_segger_offset after the shared memory is initialized by: ``` g_segger_offset = (uintptr_t)ishmem - (uintptr_t)&_SEGGER_RTT; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
