Javinator9889 commented on PR #16564: URL: https://github.com/apache/nuttx/pull/16564#issuecomment-2994364394
> > > I think this change is fine. We already have an explicit dependency on .config, so having an explicit dependency on .version makes sense to me. > > > Are there any other non-source-code files that should also trigger the full rebuild? > > > (Currently I'm only commenting; will approve once I can test the changes with an actual build.) > > > > > > A quick search shows that there are only a few usages of `version.h`: > >  > > And the `procfs` one is already being re-compiled whenever `version.h` changes - but only that file. TBH, I don't exactly understand why the `procfs` one is being recompiled while the `libc` is not. > > I think there's a bigger bug with the dependencies @xiaoxiang781216 @hartmannathan. I've tried changing any other file declared in the `Make.deps` and **the recompilation is not triggering** either. I'll take a deeper look on Monday and post here anything I find. So, I've been digging a little bit into it and I've found the root cause. This problem was already fixed on https://github.com/apache/nuttx/pull/7572 by @zouboan. The problem lies on the double delimiter. `make` is quite literally looking for a `bin//<file>` - with double dash - and it fails to find anything:  As it turns out, `make` is completely unable to find any rule that matches the requirement, so it considers it's already up-to-date. I had this problem simply because we were using an older NuttX version that doesn't include the fix. Therefore, there's no need to always remake `libc` whenever the `.version` file changes, as the `version.h` is populated correctly and `make` identifies the changes. BR, -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
