xiaoxiang781216 commented on code in PR #16623: URL: https://github.com/apache/nuttx/pull/16623#discussion_r2167411465
########## drivers/net/ncv7410.h: ########## @@ -0,0 +1,291 @@ +/**************************************************************************** + * drivers/net/ncv7410.h + * + * SPDX-License-Identifier: Apache-2.0 + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +#ifndef __DRIVERS_NET_NCV7410_H +#define __DRIVERS_NET_NCV7410_H + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/bits.h> +#include <stdint.h> + +/**************************************************************************** + * Pre-processor Definitions + ****************************************************************************/ + +/* NuttX SPI mode number for SPI config as defined in OpenAlliance TC6 */ + +#define OA_SPI_MODE 0 + +/* Number of bits in a SPI word */ + +#define OA_SPI_NBITS 8 Review Comment: why use two prefix OA_ and NCV_, and not unify to one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
