This is an automated email from the ASF dual-hosted git repository.
xiaoxiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/nuttx-apps.git
The following commit(s) were added to refs/heads/master by this push:
new bb508520f system/settings: fix assertion triggered by uninitialized
variables
bb508520f is described below
commit bb508520f1e29a532ac0df413d2714b410e96bf3
Author: Jean THOMAS <[email protected]>
AuthorDate: Wed Jun 25 14:44:57 2025 +0200
system/settings: fix assertion triggered by uninitialized variables
Fix non-NULL pointer assertion in `get_setting()` caused by
uninitialized pointer variables.
Signed-off-by: Jean THOMAS <[email protected]>
---
system/settings/settings.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/system/settings/settings.c b/system/settings/settings.c
index d6a6673af..b4fcef34f 100644
--- a/system/settings/settings.c
+++ b/system/settings/settings.c
@@ -1312,7 +1312,7 @@ errout:
int settings_type(FAR char *key, FAR enum settings_type_e *stype)
{
int ret;
- FAR setting_t *setting;
+ FAR setting_t *setting = NULL;
if (!g_settings.initialized)
{
@@ -1360,7 +1360,7 @@ int settings_type(FAR char *key, FAR enum settings_type_e
*stype)
int settings_get(FAR char *key, enum settings_type_e type, ...)
{
int ret;
- FAR setting_t *setting;
+ FAR setting_t *setting = NULL;
if (!g_settings.initialized)
{
@@ -1458,7 +1458,7 @@ errout:
int settings_set(FAR char *key, enum settings_type_e type, ...)
{
int ret;
- FAR setting_t *setting;
+ FAR setting_t *setting = NULL;
uint32_t h;
if (!g_settings.initialized)