cederom commented on code in PR #3117: URL: https://github.com/apache/nuttx-apps/pull/3117#discussion_r2179930320
########## system/nxplayer/nxplayer.c: ########## @@ -1809,11 +1842,15 @@ static int nxplayer_playinternal(FAR struct nxplayer_s *pplayer, /* Test that the specified file exists */ #ifdef CONFIG_NXPLAYER_HTTP_STREAMING_SUPPORT - if ((pplayer->fd = _open_with_http(pfilename)) == -1) + pplayer->fd = _open_with_http(pfilename); + if (pplayer->fd < 0) #else - if ((pplayer->fd = open(pfilename, O_RDONLY)) == -1) + pplayer->fd = open(pfilename, O_RDONLY); Review Comment: When splitting here please also update other places (i.e. line 1859). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
