tmedicci commented on code in PR #16672: URL: https://github.com/apache/nuttx/pull/16672#discussion_r2185237536
########## arch/xtensa/src/common/xtensa_int_handlers.S: ########## @@ -219,7 +321,7 @@ _xtensa_level1_handler: * area in a2. */ - dispatch_c_isr 1 XCHAL_INTLEVEL1_MASK a0 + dispatch_c_isr 1 a0 Review Comment: Why not using a macro for it? Usually, we avoid using literals and prefer using predefined macros to improve readability. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org