mlyszczek commented on code in PR #16714:
URL: https://github.com/apache/nuttx/pull/16714#discussion_r2201953038
##########
boards/arm/stm32/stm32f4discovery/src/stm32_bringup.c:
##########
@@ -452,6 +456,16 @@ int stm32_bringup(void)
}
#endif
+#ifdef CONFIG_INPUT_SBUTTON
+ /* Register the Single Button Dual Action driver */
+
+ ret = board_sbutton_initialize(0);
Review Comment:
I would expect function with such name to have external linkage and be
called outside of specific board. Shouldn't that be prefixed with something
like `stm32_` as you have in comment for the function? This seems internal to
stm32f4disco.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
